XXE in PHPSpreadsheet due to incomplete fix for previous encoding issue
The advisory, in context
PHPOffice PhpSpreadsheet before 1.8.0 has an XXE issue. The XmlScanner decodes the sheet1.xml from an .xlsx to utf-8 if something else than UTF-8 is declared in the header. This was a security measurement to prevent CVE-2018-19277 but the fix is not sufficient. By double-encoding the the xml payload to utf-7 it is possible to bypass the check for the string ?<!ENTITY? and thus allowing for an xml external entity processing (XXE) attack.
Affected packages
Start with the recorded fix for your release branch. Check your installed version and test compatibility before upgrading. Fixing this advisory does not rule out other vulnerabilities in the release.
Earlier releases before 1.8.0
Fixed in 1.8.0
15 explicitly affected versions
1.0.0, 1.0.0-beta, 1.0.0-beta2, 1.1.0, 1.2.0, 1.2.1, 1.3.0, 1.3.1, 1.4.0, 1.4.1, 1.5.0, 1.5.1, 1.5.2, 1.6.0, 1.7.0
View affected-version evidence
{
"ranges": [
{
"events": [
{
"introduced": "0"
},
{
"fixed": "1.8.0"
}
],
"type": "ECOSYSTEM"
}
],
"versions": [
"1.0.0",
"1.0.0-beta",
"1.0.0-beta2",
"1.1.0",
"1.2.0",
"1.2.1",
"1.3.0",
"1.3.1",
"1.4.0",
"1.4.1",
"1.5.0",
"1.5.1",
"1.5.2",
"1.6.0",
"1.7.0"
]
}Earlier releases through 1.8.2 (inclusive)
No fix recorded for this interval.
9 explicitly affected versions
1.7.9, 1.7.9-rc1, 1.8.0, 1.8.0rc1, 1.8.0rc2, 1.8.0rc3, 1.8.0rc4, 1.8.1, 1.8.2
View affected-version evidence
{
"ranges": [
{
"events": [
{
"introduced": "0"
},
{
"last_affected": "1.8.2"
}
],
"type": "ECOSYSTEM"
}
],
"versions": [
"1.7.9",
"1.7.9-rc1",
"1.8.0",
"1.8.0rc1",
"1.8.0rc2",
"1.8.0rc3",
"1.8.0rc4",
"1.8.1",
"1.8.2"
]
}References
- https://nvd.nist.gov/vuln/detail/CVE-2019-12331
- https://github.com/PHPOffice/PhpSpreadsheet/pull/1041
- https://github.com/PHPOffice/PhpSpreadsheet/commit/0e6238c69e863b58aeece61e48ea032696c6dccd
- https://github.com/FriendsOfPHP/security-advisories/blob/master/phpoffice/phpspreadsheet/CVE-2019-12331.yaml
- https://github.com/PHPOffice/PhpSpreadsheet
- https://github.com/PHPOffice/PhpSpreadsheet/blob/master/CHANGELOG.md#180---2019-07-01
- https://github.com/PHPOffice/PhpSpreadsheet/releases/tag/1.8.0
- https://herolab.usd.de/security-advisories/usd-2019-0046