GHSA-v66g-p9x6-v98pmedium6.1

PhpSpreadsheet has an Unauthenticated Cross-Site-Scripting (XSS) in sample file

The advisory, in context

Summary

One of the sample scripts in PhpSpreadsheet is susceptible to a cross-site scripting (XSS) vulnerability due to improper handling of input where a number is expected leading to formula injection.

Details

The following code in 45_Quadratic_equation_solver.php concatenates the user supplied parameters directly into spreadsheet formulas. This allows an attacker to take control over the formula and output unsanitized data into the page, resulting in JavaScript execution.

$discriminantFormula = '=POWER(' . $_POST['B'] . ',2) - (4 * ' . $_POST['A'] . ' * ' . $_POST['C'] . ')';
$discriminant = Calculation::getInstance()->calculateFormula($discriminantFormula);

$r1Formula = '=IMDIV(IMSUM(-' . $_POST['B'] . ',IMSQRT(' . $discriminant . ')),2 * ' . $_POST['A'] . ')';
$r2Formula = '=IF(' . $discriminant . '=0,"Only one root",IMDIV(IMSUB(-' . $_POST['B'] . ',IMSQRT(' . $discriminant . ')),2 * ' . $_POST['A'] . '))';

PoC

Access 45_Quadratic_equation_solver.php in a browser
Enter any valid values for for b and c, and enter the following for a

1) & ("1)),1)&char(60)&char(105)&char(109)&char(103)&char(32)&char(115)&char(114)&char(99)&char(61)&char(120)&char(32)&char(111)&char(110)&char(101)&char(114)&char(114)&char(111)&char(114)&char(61)&char(97)&char(108)&char(101)&char(114)&char(116)&char(40)&char(41)&char(62)&POWER(((1") &n("1")&(1

Press submit and observe that JavaScript is executed.

exploit-phpspreadsheet

Impact

The impact of this vulnerability on the project is expected to be relatively low since these are sample files that should not be included when the library is used properly (e.g., through composer). However, at least two instances of popular WordPress plugins have unintentionally exposed this file by including the entire git repository. Since these files also serve as reference points for developers using the library, addressing this issue can enhance security for users.

A solution to fix the vulnerability is proposed below, and a request for a CVE assignment has been made to facilitate responsible disclosure of the security issue to the affected WordPress plugins.

Remediation

A quick and easy solution to prevent this attack is to force the parameters to be numerical values:

if (isset($_POST['submit'])) {
    $_POST['A'] = floatval($_POST['A']);
    $_POST['B'] = floatval($_POST['B']);
    $_POST['C'] = floatval($_POST['C']);
    if ($_POST['A'] == 0) {

Thank you for your time!

Affected packages

Start with the recorded fix for your release branch. Check your installed version and test compatibility before upgrading. Fixing this advisory does not rule out other vulnerabilities in the release.

phpoffice/phpspreadsheet Packagist

Ecosystem versions

From 2.2.0 before 2.3.0

Fixed in 2.3.0

3 explicitly affected versions

2.2.0, 2.2.1, 2.2.2

View affected-version evidence

{
  "ranges": [
    {
      "events": [
        {
          "introduced": "2.2.0"
        },
        {
          "fixed": "2.3.0"
        }
      ],
      "type": "ECOSYSTEM"
    }
  ],
  "versions": [
    "2.2.0",
    "2.2.1",
    "2.2.2"
  ]
}

phpoffice/phpspreadsheet Packagist

Ecosystem versions

Earlier releases before 1.29.2

Fixed in 1.29.2

47 explicitly affected versions

1.0.0, 1.0.0-beta, 1.0.0-beta2, 1.1.0, 1.10.0, 1.10.1, 1.11.0, 1.12.0, 1.13.0, 1.14.0, 1.14.1, 1.15.0, 1.16.0, 1.17.0, 1.17.1, 1.18.0, 1.19.0, 1.2.0, 1.2.1, 1.20.0, 1.21.0, 1.22.0, 1.23.0, 1.24.0, 1.24.1, 1.25.0, 1.25.1, 1.25.2, 1.26.0, 1.27.0, 1.27.1, 1.28.0, 1.29.0, 1.29.1, 1.3.0, 1.3.1, 1.4.0, 1.4.1, 1.5.0, 1.5.1, 1.5.2, 1.6.0, 1.7.0, 1.8.0, 1.8.1, 1.8.2, 1.9.0

View affected-version evidence

{
  "ranges": [
    {
      "events": [
        {
          "introduced": "0"
        },
        {
          "fixed": "1.29.2"
        }
      ],
      "type": "ECOSYSTEM"
    }
  ],
  "versions": [
    "1.0.0",
    "1.0.0-beta",
    "1.0.0-beta2",
    "1.1.0",
    "1.10.0",
    "1.10.1",
    "1.11.0",
    "1.12.0",
    "1.13.0",
    "1.14.0",
    "1.14.1",
    "1.15.0",
    "1.16.0",
    "1.17.0",
    "1.17.1",
    "1.18.0",
    "1.19.0",
    "1.2.0",
    "1.2.1",
    "1.20.0",
    "1.21.0",
    "1.22.0",
    "1.23.0",
    "1.24.0",
    "1.24.1",
    "1.25.0",
    "1.25.1",
    "1.25.2",
    "1.26.0",
    "1.27.0",
    "1.27.1",
    "1.28.0",
    "1.29.0",
    "1.29.1",
    "1.3.0",
    "1.3.1",
    "1.4.0",
    "1.4.1",
    "1.5.0",
    "1.5.1",
    "1.5.2",
    "1.6.0",
    "1.7.0",
    "1.8.0",
    "1.8.1",
    "1.8.2",
    "1.9.0"
  ]
}

phpoffice/phpspreadsheet Packagist

Ecosystem versions

From 2.0.0 before 2.1.1

Fixed in 2.1.1

2 explicitly affected versions

2.0.0, 2.1.0

View affected-version evidence

{
  "ranges": [
    {
      "events": [
        {
          "introduced": "2.0.0"
        },
        {
          "fixed": "2.1.1"
        }
      ],
      "type": "ECOSYSTEM"
    }
  ],
  "versions": [
    "2.0.0",
    "2.1.0"
  ]
}

phpoffice/phpexcel Packagist

Ecosystem versions

Earlier releases through 1.8.2 (inclusive)

No fix recorded for this interval.

9 explicitly affected versions

1.7.9, 1.7.9-rc1, 1.8.0, 1.8.0rc1, 1.8.0rc2, 1.8.0rc3, 1.8.0rc4, 1.8.1, 1.8.2

View affected-version evidence

{
  "ranges": [
    {
      "events": [
        {
          "introduced": "0"
        },
        {
          "last_affected": "1.8.2"
        }
      ],
      "type": "ECOSYSTEM"
    }
  ],
  "versions": [
    "1.7.9",
    "1.7.9-rc1",
    "1.8.0",
    "1.8.0rc1",
    "1.8.0rc2",
    "1.8.0rc3",
    "1.8.0rc4",
    "1.8.1",
    "1.8.2"
  ]
}

Set up in your agent.

Investigate in your agent.

PhpSpreadsheet has an Unauthenticated Cross-Site-Scripting (XSS) in sample file

The advisory, in context

Summary

Details

PoC

Impact

Remediation

Affected packages

References