silverstripe/framework's `Member.Name` is not escaped
The advisory, in context
The core template framework/templates/Includes/GridField_print.ss uses "Printed by $Member.Name".
If the currently logged in members first name or surname contain XSS, this prints the raw HTML out, because Member->getName() just returns the raw FirstName + Surname as a string, which is injected directly.
Affected packages
Start with the recorded fix for your release branch. Check your installed version and test compatibility before upgrading. Fixing this advisory does not rule out other vulnerabilities in the release.
From 3.1.9-rc1 before 3.1.20
Fixed in 3.1.20
25 explicitly affected versions
3.1.10, 3.1.10-rc1, 3.1.10-rc2, 3.1.11, 3.1.11-rc1, 3.1.12, 3.1.13, 3.1.13-rc1, 3.1.14, 3.1.14-rc1, 3.1.15, 3.1.16, 3.1.16-rc1, 3.1.17, 3.1.17-rc1, 3.1.17-rc2, 3.1.18, 3.1.18-rc1, 3.1.18-rc2, 3.1.19, 3.1.19-rc1, 3.1.20-rc1, 3.1.20-rc2, 3.1.9, 3.1.9-rc1
View affected-version evidence
{
"ranges": [
{
"events": [
{
"introduced": "3.1.9-rc1"
},
{
"fixed": "3.1.20"
}
],
"type": "ECOSYSTEM"
}
],
"versions": [
"3.1.10",
"3.1.10-rc1",
"3.1.10-rc2",
"3.1.11",
"3.1.11-rc1",
"3.1.12",
"3.1.13",
"3.1.13-rc1",
"3.1.14",
"3.1.14-rc1",
"3.1.15",
"3.1.16",
"3.1.16-rc1",
"3.1.17",
"3.1.17-rc1",
"3.1.17-rc2",
"3.1.18",
"3.1.18-rc1",
"3.1.18-rc2",
"3.1.19",
"3.1.19-rc1",
"3.1.20-rc1",
"3.1.20-rc2",
"3.1.9",
"3.1.9-rc1"
]
}From 3.2.4-rc1 before 3.2.5
Fixed in 3.2.5
4 explicitly affected versions
3.2.4, 3.2.4-rc1, 3.2.5-rc1, 3.2.5-rc2
View affected-version evidence
{
"ranges": [
{
"events": [
{
"introduced": "3.2.4-rc1"
},
{
"fixed": "3.2.5"
}
],
"type": "ECOSYSTEM"
}
],
"versions": [
"3.2.4",
"3.2.4-rc1",
"3.2.5-rc1",
"3.2.5-rc2"
]
}From 3.3.2-rc1 before 3.3.3
Fixed in 3.3.3
4 explicitly affected versions
3.3.2, 3.3.2-rc1, 3.3.3-rc1, 3.3.3-rc2
View affected-version evidence
{
"ranges": [
{
"events": [
{
"introduced": "3.3.2-rc1"
},
{
"fixed": "3.3.3"
}
],
"type": "ECOSYSTEM"
}
],
"versions": [
"3.3.2",
"3.3.2-rc1",
"3.3.3-rc1",
"3.3.3-rc2"
]
}From 3.4.0-rc1 before 3.4.1
Fixed in 3.4.1
4 explicitly affected versions
3.4.0, 3.4.0-rc1, 3.4.1-rc1, 3.4.1-rc2
View affected-version evidence
{
"ranges": [
{
"events": [
{
"introduced": "3.4.0-rc1"
},
{
"fixed": "3.4.1"
}
],
"type": "ECOSYSTEM"
}
],
"versions": [
"3.4.0",
"3.4.0-rc1",
"3.4.1-rc1",
"3.4.1-rc2"
]
}References
- https://github.com/silverstripe/silverstripe-framework/commit/281b0de571fe0ae159ac47891c02acf2214fa619
- https://github.com/silverstripe/silverstripe-framework/commit/6817c57f64b9eb2b271b81662cd83b074a3daee4
- https://github.com/silverstripe/silverstripe-framework/commit/83e3302c0425d9b0e4fe42e82e3df03379f4dca5
- https://github.com/silverstripe/silverstripe-framework/commit/8bbf1caae665a07b3e44e8d5d32556a03d38c296
- https://github.com/FriendsOfPHP/security-advisories/blob/master/silverstripe/framework/SS-2016-013-1.yaml
- https://github.com/silverstripe/silverstripe-framework
- https://www.silverstripe.org/download/security-releases/ss-2016-013