silverstripe/framework users inadvertently passing sensitive data to LoginAttempt
The advisory, in context
All user login attempts are logged in the database in the LoginAttempt table. However, this table contains information in plain text, and may possible contain sensitive information, such as user passwords mis-typed into the username field.
In order to address this a one-way hash is applied to the Email field before being stored.
Affected packages
Start with the recorded fix for your release branch. Check your installed version and test compatibility before upgrading. Fixing this advisory does not rule out other vulnerabilities in the release.
From 3.5.0-rc1 before 3.5.6
Fixed in 3.5.6
17 explicitly affected versions
3.5.0, 3.5.0-rc1, 3.5.0-rc2, 3.5.0-rc3, 3.5.1, 3.5.1-rc1, 3.5.1-rc2, 3.5.2, 3.5.2-rc1, 3.5.3, 3.5.3-rc1, 3.5.4, 3.5.4-rc1, 3.5.5, 3.5.5-beta1, 3.5.5-beta2, 3.5.6-rc1
View affected-version evidence
{
"ranges": [
{
"events": [
{
"introduced": "3.5.0-rc1"
},
{
"fixed": "3.5.6"
}
],
"type": "ECOSYSTEM"
}
],
"versions": [
"3.5.0",
"3.5.0-rc1",
"3.5.0-rc2",
"3.5.0-rc3",
"3.5.1",
"3.5.1-rc1",
"3.5.1-rc2",
"3.5.2",
"3.5.2-rc1",
"3.5.3",
"3.5.3-rc1",
"3.5.4",
"3.5.4-rc1",
"3.5.5",
"3.5.5-beta1",
"3.5.5-beta2",
"3.5.6-rc1"
]
}From 3.6.0-rc1 before 3.6.3
Fixed in 3.6.3
8 explicitly affected versions
3.6.0, 3.6.0-rc1, 3.6.1, 3.6.1-alpha2, 3.6.2, 3.6.2-beta1, 3.6.2-beta2, 3.6.3-rc2
View affected-version evidence
{
"ranges": [
{
"events": [
{
"introduced": "3.6.0-rc1"
},
{
"fixed": "3.6.3"
}
],
"type": "ECOSYSTEM"
}
],
"versions": [
"3.6.0",
"3.6.0-rc1",
"3.6.1",
"3.6.1-alpha2",
"3.6.2",
"3.6.2-beta1",
"3.6.2-beta2",
"3.6.3-rc2"
]
}From 4.0.0-rc1 before 4.0.1
Fixed in 4.0.1
5 explicitly affected versions
4.0.0, 4.0.0-rc1, 4.0.0-rc2, 4.0.0-rc3, 4.0.1-rc1
View affected-version evidence
{
"ranges": [
{
"events": [
{
"introduced": "4.0.0-rc1"
},
{
"fixed": "4.0.1"
}
],
"type": "ECOSYSTEM"
}
],
"versions": [
"4.0.0",
"4.0.0-rc1",
"4.0.0-rc2",
"4.0.0-rc3",
"4.0.1-rc1"
]
}References
- https://github.com/silverstripe/silverstripe-framework/commit/3e2bcaa0b49277ff7f7004b265a7fa80d0b92e5c
- https://github.com/silverstripe/silverstripe-framework/commit/c5d6eb816d4ac5e9fa3d8bc4bd82de95719eb22d
- https://github.com/silverstripe/silverstripe-framework/commit/f1dd3d6f03eb1d94c29c495994a1da9176a758d9
- https://github.com/FriendsOfPHP/security-advisories/blob/master/silverstripe/framework/SS-2017-009-1.yaml
- https://github.com/silverstripe/silverstripe-framework
- https://www.silverstripe.org/download/security-releases/ss-2017-009