GHSA-hx53-jchx-cr52 — Symfony2 improper IP based access control

The advisory, in context

Damien Tournoud, from the Drupal security team, contacted us two days ago about a security issue in the Request::getClientIp() method when the trust proxy mode is enabled (Request::trustProxyData()).

An application is vulnerable if it uses the client IP address as returned by the Request::getClientIp() method for sensitive decisions like IP based access control.

To fix this security issue, the following changes have been made to all versions of Symfony2:

A new Request::setTrustedProxies() method has been introduced and should be used intead of Request::trustProxyData() to enable the trust proxy mode. It takes an array of trusted proxy IP addresses as its argument:

// before (probably in your front controller script)
Request::trustProxyData();

// after
Request::setTrustedProxies(array('1.1.1.1'));
// 1.1.1.1 being the IP address of a trusted reverse proxy

The Request::trustProxyData() method has been deprecated (when used, it automatically trusts the latest proxy in the chain -- which is the current remote address):

Request::trustProxyData();

// is equivalent to
Request::setTrustedProxies(array($request->server->get('REMOTE_ADDR')));

We encourage all Symfony2 users to upgrade as soon as possible. It you don't want to upgrade to the latest version yet, you can also apply the following patches:

Patch for Symfony 2.0.19 Patch for Symfony 2.1.4

Affected packages

Start with the recorded fix for your release branch. Check your installed version and test compatibility before upgrading. Fixing this advisory does not rule out other vulnerabilities in the release.

symfony/symfony Packagist

Ecosystem versions

From 2.0.0 before 2.0.19

Fixed in 2.0.19

14 explicitly affected versions

2.0.4, 2.0.5, 2.0.6, 2.0.7, v2.0.10, v2.0.11, v2.0.12, v2.0.13, v2.0.14, v2.0.15, v2.0.16, v2.0.17, v2.0.18, v2.0.9

View affected-version evidence

{
  "ranges": [
    {
      "events": [
        {
          "introduced": "2.0.0"
        },
        {
          "fixed": "2.0.19"
        }
      ],
      "type": "ECOSYSTEM"
    }
  ],
  "versions": [
    "2.0.4",
    "2.0.5",
    "2.0.6",
    "2.0.7",
    "v2.0.10",
    "v2.0.11",
    "v2.0.12",
    "v2.0.13",
    "v2.0.14",
    "v2.0.15",
    "v2.0.16",
    "v2.0.17",
    "v2.0.18",
    "v2.0.9"
  ]
}

symfony/symfony Packagist

Ecosystem versions

From 2.1.0 before 2.1.4

Fixed in 2.1.4

4 explicitly affected versions

v2.1.0, v2.1.1, v2.1.2, v2.1.3

View affected-version evidence

{
  "ranges": [
    {
      "events": [
        {
          "introduced": "2.1.0"
        },
        {
          "fixed": "2.1.4"
        }
      ],
      "type": "ECOSYSTEM"
    }
  ],
  "versions": [
    "v2.1.0",
    "v2.1.1",
    "v2.1.2",
    "v2.1.3"
  ]
}

Set up in your agent.

Investigate in your agent.

Symfony2 improper IP based access control

The advisory, in context

Affected packages

References