FriendsOfFlarum OAuth: Unauthenticated account takeover via unverified email trust in Discord OAuth provider

Impact

An unauthenticated account takeover vulnerability exists in fof/oauth when the Discord OAuth provider is enabled.

Discord allows an account to use an unverified email address when its phone number has been verified. During OAuth authentication, Discord may return that email address with "verified": false.

Affected versions of fof/oauth did not validate this flag and passed the email address to Flarum core as trusted via provideTrustedEmail(). Flarum core could then match the trusted email address to an existing user, link the attacker-controlled Discord identity to that user, and authenticate the attacker as the victim.

An attacker who knows a user's email address can therefore take over the corresponding Flarum account without knowing its password or requiring any interaction from the victim. This includes administrator accounts.

Preconditions for exploitation

1. Discord sign-in is enabled on the forum.
2. The victim has a Flarum account with a known email address.
3. The victim's email address is not already associated with a Discord account.
4. The attacker creates or configures a Discord account using the victim's email address without verifying it and verifies a phone number instead.
5. The attacker authenticates to the forum using that Discord account.

The issue is specific to Discord's ability to return an unverified email address through OAuth. Other bundled providers were not confirmed to be practically exploitable through the same method because they only return verified or confirmed email addresses in the relevant authentication flow.

Patched Versions

• 1.7.4
• 2.0.0-beta.4

Workarounds

Administrators who cannot update immediately should disable the Discord OAuth provider in the extension settings.

Credits

Reported by @faran1512