Sylius has potential Cross Site Scripting vulnerability via the "Province" field in the Checkout and Address Book
The advisory, in context
Impact
There is a possibility to save XSS code in province field in the Checkout and Address Book and then execute it on these pages. The problem occurs when you open the address step page in the checkout or edit the address in the address book. This only affects the base UI Shop provided by Sylius.
Patches
The issue is fixed in versions: 1.9.12, 1.10.16, 1.11.17, 1.12.16, 1.13.1 and above.
Workarounds
- Create new file
assets/shop/sylius-province-field.js:
// assets/shop/sylius-province-field.js
function sanitizeInput(input) {
const div = document.createElement('div');
div.textContent = input;
return div.innerHTML; // Converts text content to plain HTML, stripping any scripts
}
const getProvinceInputValue = function getProvinceInputValue(valueSelector) {
return valueSelector == undefined ? '' : `value="${sanitizeInput(valueSelector)}"`;
};
$.fn.extend({
provinceField() {
const countrySelect = $('select[name$="[countryCode]"]');
countrySelect.on('change', (event) => {
const select = $(event.currentTarget);
const provinceContainer = select.parents('.field').next('div.province-container');
const provinceSelectFieldName = select.attr('name').replace('country', 'province');
const provinceInputFieldName = select.attr('name').replace('countryCode', 'provinceName');
const provinceSelectFieldId = select.attr('id').replace('country', 'province');
const provinceInputFieldId = select.attr('id').replace('countryCode', 'provinceName');
const form = select.parents('form');
if (select.val() === '' || select.val() == undefined) {
provinceContainer.fadeOut('slow', () => {
provinceContainer.html('');
});
return;
}
provinceContainer.attr('data-loading', true);
form.addClass('loading');
$.get(provinceContainer.attr('data-url'), { countryCode: select.val() }, (response) => {
if (!response.content) {
provinceContainer.fadeOut('slow', () => {
provinceContainer.html('');
provinceContainer.removeAttr('data-loading');
form.removeClass('loading');
});
} else if (response.content.indexOf('select') !== -1) {
provinceContainer.fadeOut('slow', () => {
const provinceSelectValue = getProvinceInputValue((
$(provinceContainer).find('select > option[selected$="selected"]').val()
));
provinceContainer.html((
response.content
.replace('name="sylius_address_province"', `name="${provinceSelectFieldName}"${provinceSelectValue}`)
.replace('id="sylius_address_province"', `id="${provinceSelectFieldId}"`)
.replace('option value="" selected="selected"', 'option value=""')
.replace(`option ${provinceSelectValue}`, `option ${provinceSelectValue}" selected="selected"`)
));
provinceContainer.addClass('required');
provinceContainer.removeAttr('data-loading');
provinceContainer.fadeIn('fast', () => {
form.removeClass('loading');
});
});
} else {
provinceContainer.fadeOut('slow', () => {
const provinceInputValue = getProvinceInputValue($(provinceContainer).find('input').val());
provinceContainer.html((
response.content
.replace('name="sylius_address_province"', `name="${provinceInputFieldName}"${provinceInputValue}`)
.replace('id="sylius_address_province"', `id="${provinceInputFieldId}"`)
));
provinceContainer.removeAttr('data-loading');
provinceContainer.fadeIn('fast', () => {
form.removeClass('loading');
});
});
}
});
});
if (countrySelect.val() !== '') {
countrySelect.trigger('change');
}
if ($.trim($('div.province-container').text()) === '') {
$('select.country-select').trigger('change');
}
const shippingAddressCheckbox = $('input[type="checkbox"][name$="[differentShippingAddress]"]');
const shippingAddressContainer = $('#sylius-shipping-address-container');
const toggleShippingAddress = function toggleShippingAddress() {
shippingAddressContainer.toggle(shippingAddressCheckbox.prop('checked'));
};
toggleShippingAddress();
shippingAddressCheckbox.on('change', toggleShippingAddress);
},
});
- Add new import in
assets/shop/entry.js:
// assets/shop/entry.js
// ...
import './sylius-province-field';
- If you're using Gulp, update your
gulpfile.babel.js:
import chug from 'gulp-chug';
+ import concat from 'gulp-concat';
import gulp from 'gulp';
import yargs from 'yargs';
const { argv } = ...
+ const rootPath = argv.rootPath || 'public/assets';
+
const config = [...];
'--rootPath',
argv.rootPath || '../../../../../../../public/assets',
'--nodeModulesPath',
argv.nodeModulesPath || '../../../../../../../node_modules',
];
...
export const buildShop = ...
+ export const patchShopJs = function patchShopJs() {
+ return gulp.src([
+ `${rootPath}/shop/js/app.js`,
+ 'assets/shop/sylius-province-field.js',
+ ])
+ .pipe(concat('app.js'))
+ .pipe(gulp.dest(`${rootPath}/shop/js`));
+ };
+ patchShopJs.description = 'Append shop security patches to built app.js.';
...
- export const build = gulp.parallel(buildAdmin, buildShop);
+ export const build = gulp.series(
+ gulp.parallel(buildAdmin, buildShop),
+ patchShopJs,
+ );
...
- gulp.task('shop', buildShop);
+ gulp.task('shop', gulp.series(buildShop, patchShopJs));
...
- Rebuild your assets:
yarn build
Acknowledgements
This security issue has been reported by @r2tunes, thank you!
References
- The original advisory: https://github.com/advisories/GHSA-mw82-6m2g-qh6c
For more information
If you have any questions or comments about this advisory:
- Open an issue in Sylius issues
- Email us at security@sylius.com
Affected packages
Start with the recorded fix for your release branch. Check your installed version and test compatibility before upgrading. Fixing this advisory does not rule out other vulnerabilities in the release.
Earlier releases before 1.9.12
Fixed in 1.9.12
188 explicitly affected versions
v0.1.0, v0.10.0, v0.11.0, v0.12.0, v0.13.0, v0.14.0, v0.15.0, v0.16.0, v0.17.0, v0.18.0, v0.19.0, v0.2.0, v0.3.0, v0.5.0, v0.6.0, v0.7.0, v0.8.0, v0.9.0, v1.0.0, v1.0.0-alpha.1, v1.0.0-alpha.2, v1.0.0-beta.1, v1.0.0-beta.2, v1.0.0-beta.3, v1.0.0-rc.1, v1.0.0-rc.2, v1.0.1, v1.0.10, v1.0.11, v1.0.12, v1.0.13, v1.0.14, v1.0.15, v1.0.16, v1.0.17, v1.0.18, v1.0.2, v1.0.3, v1.0.4, v1.0.5, v1.0.6, v1.0.7, v1.0.8, v1.0.9, v1.1.0, v1.1.0-RC, v1.1.1, v1.1.10, v1.1.11, v1.1.12, v1.1.13, v1.1.14, v1.1.15, v1.1.16, v1.1.17, v1.1.18, v1.1.2, v1.1.3, v1.1.4, v1.1.5, v1.1.6, v1.1.7, v1.1.8, v1.1.9, v1.2.0, v1.2.0-BETA, v1.2.0-RC, v1.2.1, v1.2.10, v1.2.11, v1.2.12, v1.2.13, v1.2.14, v1.2.15, v1.2.16, v1.2.17, v1.2.2, v1.2.3, v1.2.4, v1.2.5, v1.2.6, v1.2.7, v1.2.8, v1.2.9, v1.3.0, v1.3.0-BETA, v1.3.1, v1.3.10, v1.3.11, v1.3.12, v1.3.13, v1.3.14, v1.3.15, v1.3.16, v1.3.2, v1.3.3, v1.3.4, v1.3.5, v1.3.6, v1.3.7, v1.3.8, v1.3.9, v1.4.0, v1.4.0-BETA.1, v1.4.1, v1.4.10, v1.4.11, v1.4.12, v1.4.2, v1.4.3, v1.4.4, v1.4.5, v1.4.6, v1.4.7, v1.4.8, v1.4.9, v1.5.0, v1.5.0-RC.1, v1.5.1, v1.5.2, v1.5.3, v1.5.4, v1.5.5, v1.5.6, v1.5.7, v1.5.8, v1.5.9, v1.6.0, v1.6.0-ALPHA.1, v1.6.0-ALPHA.2, v1.6.0-RC.1, v1.6.1, v1.6.2, v1.6.3, v1.6.4, v1.6.5, v1.6.6, v1.6.7, v1.6.8, v1.6.9, v1.7.0, v1.7.0-ALPHA.1, v1.7.0-ALPHA.2, v1.7.0-RC.1, v1.7.1, v1.7.10, v1.7.11, v1.7.2, v1.7.3, v1.7.4, v1.7.5, v1.7.6, v1.7.7, v1.7.8, v1.7.9, v1.8.0, v1.8.0-RC.1, v1.8.1, v1.8.10, v1.8.11, v1.8.12, v1.8.2, v1.8.3, v1.8.4, v1.8.5, v1.8.6, v1.8.7, v1.8.8, v1.8.9, v1.9.0, v1.9.0-ALPHA.1, v1.9.0-ALPHA.2, v1.9.0-BETA.1, v1.9.0-BETA.2, v1.9.0-BETA.3, v1.9.0-RC.1, v1.9.0-RC.2, v1.9.1, v1.9.10, v1.9.11, v1.9.2, v1.9.3, v1.9.4, v1.9.5, v1.9.6, v1.9.7, v1.9.8, v1.9.9
View affected-version evidence
{
"ranges": [
{
"events": [
{
"introduced": "0"
},
{
"fixed": "1.9.12"
}
],
"type": "ECOSYSTEM"
}
],
"versions": [
"v0.1.0",
"v0.10.0",
"v0.11.0",
"v0.12.0",
"v0.13.0",
"v0.14.0",
"v0.15.0",
"v0.16.0",
"v0.17.0",
"v0.18.0",
"v0.19.0",
"v0.2.0",
"v0.3.0",
"v0.5.0",
"v0.6.0",
"v0.7.0",
"v0.8.0",
"v0.9.0",
"v1.0.0",
"v1.0.0-alpha.1",
"v1.0.0-alpha.2",
"v1.0.0-beta.1",
"v1.0.0-beta.2",
"v1.0.0-beta.3",
"v1.0.0-rc.1",
"v1.0.0-rc.2",
"v1.0.1",
"v1.0.10",
"v1.0.11",
"v1.0.12",
"v1.0.13",
"v1.0.14",
"v1.0.15",
"v1.0.16",
"v1.0.17",
"v1.0.18",
"v1.0.2",
"v1.0.3",
"v1.0.4",
"v1.0.5",
"v1.0.6",
"v1.0.7",
"v1.0.8",
"v1.0.9",
"v1.1.0",
"v1.1.0-RC",
"v1.1.1",
"v1.1.10",
"v1.1.11",
"v1.1.12",
"v1.1.13",
"v1.1.14",
"v1.1.15",
"v1.1.16",
"v1.1.17",
"v1.1.18",
"v1.1.2",
"v1.1.3",
"v1.1.4",
"v1.1.5",
"v1.1.6",
"v1.1.7",
"v1.1.8",
"v1.1.9",
"v1.2.0",
"v1.2.0-BETA",
"v1.2.0-RC",
"v1.2.1",
"v1.2.10",
"v1.2.11",
"v1.2.12",
"v1.2.13",
"v1.2.14",
"v1.2.15",
"v1.2.16",
"v1.2.17",
"v1.2.2",
"v1.2.3",
"v1.2.4",
"v1.2.5",
"v1.2.6",
"v1.2.7",
"v1.2.8",
"v1.2.9",
"v1.3.0",
"v1.3.0-BETA",
"v1.3.1",
"v1.3.10",
"v1.3.11",
"v1.3.12",
"v1.3.13",
"v1.3.14",
"v1.3.15",
"v1.3.16",
"v1.3.2",
"v1.3.3",
"v1.3.4",
"v1.3.5",
"v1.3.6",
"v1.3.7",
"v1.3.8",
"v1.3.9",
"v1.4.0",
"v1.4.0-BETA.1",
"v1.4.1",
"v1.4.10",
"v1.4.11",
"v1.4.12",
"v1.4.2",
"v1.4.3",
"v1.4.4",
"v1.4.5",
"v1.4.6",
"v1.4.7",
"v1.4.8",
"v1.4.9",
"v1.5.0",
"v1.5.0-RC.1",
"v1.5.1",
"v1.5.2",
"v1.5.3",
"v1.5.4",
"v1.5.5",
"v1.5.6",
"v1.5.7",
"v1.5.8",
"v1.5.9",
"v1.6.0",
"v1.6.0-ALPHA.1",
"v1.6.0-ALPHA.2",
"v1.6.0-RC.1",
"v1.6.1",
"v1.6.2",
"v1.6.3",
"v1.6.4",
"v1.6.5",
"v1.6.6",
"v1.6.7",
"v1.6.8",
"v1.6.9",
"v1.7.0",
"v1.7.0-ALPHA.1",
"v1.7.0-ALPHA.2",
"v1.7.0-RC.1",
"v1.7.1",
"v1.7.10",
"v1.7.11",
"v1.7.2",
"v1.7.3",
"v1.7.4",
"v1.7.5",
"v1.7.6",
"v1.7.7",
"v1.7.8",
"v1.7.9",
"v1.8.0",
"v1.8.0-RC.1",
"v1.8.1",
"v1.8.10",
"v1.8.11",
"v1.8.12",
"v1.8.2",
"v1.8.3",
"v1.8.4",
"v1.8.5",
"v1.8.6",
"v1.8.7",
"v1.8.8",
"v1.8.9",
"v1.9.0",
"v1.9.0-ALPHA.1",
"v1.9.0-ALPHA.2",
"v1.9.0-BETA.1",
"v1.9.0-BETA.2",
"v1.9.0-BETA.3",
"v1.9.0-RC.1",
"v1.9.0-RC.2",
"v1.9.1",
"v1.9.10",
"v1.9.11",
"v1.9.2",
"v1.9.3",
"v1.9.4",
"v1.9.5",
"v1.9.6",
"v1.9.7",
"v1.9.8",
"v1.9.9"
]
}From 1.10.0-alpha.1 before 1.10.16
Fixed in 1.10.16
19 explicitly affected versions
v1.10.0, v1.10.0-alpha.1, v1.10.0-beta.1, v1.10.0-rc.1, v1.10.1, v1.10.10, v1.10.11, v1.10.12, v1.10.13, v1.10.14, v1.10.15, v1.10.2, v1.10.3, v1.10.4, v1.10.5, v1.10.6, v1.10.7, v1.10.8, v1.10.9
View affected-version evidence
{
"ranges": [
{
"events": [
{
"introduced": "1.10.0-alpha.1"
},
{
"fixed": "1.10.16"
}
],
"type": "ECOSYSTEM"
}
],
"versions": [
"v1.10.0",
"v1.10.0-alpha.1",
"v1.10.0-beta.1",
"v1.10.0-rc.1",
"v1.10.1",
"v1.10.10",
"v1.10.11",
"v1.10.12",
"v1.10.13",
"v1.10.14",
"v1.10.15",
"v1.10.2",
"v1.10.3",
"v1.10.4",
"v1.10.5",
"v1.10.6",
"v1.10.7",
"v1.10.8",
"v1.10.9"
]
}From 1.11.0-alpha.1 before 1.11.17
Fixed in 1.11.17
21 explicitly affected versions
v1.11.0, v1.11.0-alpha.1, v1.11.0-alpha.2, v1.11.0-beta.1, v1.11.0-rc.1, v1.11.1, v1.11.10, v1.11.11, v1.11.12, v1.11.13, v1.11.14, v1.11.15, v1.11.16, v1.11.2, v1.11.3, v1.11.4, v1.11.5, v1.11.6, v1.11.7, v1.11.8, v1.11.9
View affected-version evidence
{
"ranges": [
{
"events": [
{
"introduced": "1.11.0-alpha.1"
},
{
"fixed": "1.11.17"
}
],
"type": "ECOSYSTEM"
}
],
"versions": [
"v1.11.0",
"v1.11.0-alpha.1",
"v1.11.0-alpha.2",
"v1.11.0-beta.1",
"v1.11.0-rc.1",
"v1.11.1",
"v1.11.10",
"v1.11.11",
"v1.11.12",
"v1.11.13",
"v1.11.14",
"v1.11.15",
"v1.11.16",
"v1.11.2",
"v1.11.3",
"v1.11.4",
"v1.11.5",
"v1.11.6",
"v1.11.7",
"v1.11.8",
"v1.11.9"
]
}From 1.12.0-alpha.1 before 1.12.16
Fixed in 1.12.16
20 explicitly affected versions
v1.12.0, v1.12.0-alpha.1, v1.12.0-alpha.2, v1.12.0-beta.1, v1.12.0-rc.1, v1.12.1, v1.12.10, v1.12.11, v1.12.12, v1.12.13, v1.12.14, v1.12.15, v1.12.2, v1.12.3, v1.12.4, v1.12.5, v1.12.6, v1.12.7, v1.12.8, v1.12.9
View affected-version evidence
{
"ranges": [
{
"events": [
{
"introduced": "1.12.0-alpha.1"
},
{
"fixed": "1.12.16"
}
],
"type": "ECOSYSTEM"
}
],
"versions": [
"v1.12.0",
"v1.12.0-alpha.1",
"v1.12.0-alpha.2",
"v1.12.0-beta.1",
"v1.12.0-rc.1",
"v1.12.1",
"v1.12.10",
"v1.12.11",
"v1.12.12",
"v1.12.13",
"v1.12.14",
"v1.12.15",
"v1.12.2",
"v1.12.3",
"v1.12.4",
"v1.12.5",
"v1.12.6",
"v1.12.7",
"v1.12.8",
"v1.12.9"
]
}From 1.13.0-alpha.1 before 1.13.1
Fixed in 1.13.1
5 explicitly affected versions
v1.13.0, v1.13.0-alpha.1, v1.13.0-alpha.2, v1.13.0-beta.1, v1.13.0-rc.1
View affected-version evidence
{
"ranges": [
{
"events": [
{
"introduced": "1.13.0-alpha.1"
},
{
"fixed": "1.13.1"
}
],
"type": "ECOSYSTEM"
}
],
"versions": [
"v1.13.0",
"v1.13.0-alpha.1",
"v1.13.0-alpha.2",
"v1.13.0-beta.1",
"v1.13.0-rc.1"
]
}