GHSA-7m8g-fprr-47fxmedium6.5

phpMyFAQ vulnerable to stored XSS on attachments filename

The advisory, in context

Summary

Unsafe echo of filename in phpMyFAQ\phpmyfaq\admin\attachments.php leading to allow execute JavaScript code in client side (XSS)

Details

On that snippet code of rendering the file attachments from user tables

<?php foreach ($crumbs as $item) : ?>
        <tr id="attachment_<?= $item->id ?>" title="<?= $item->thema ?>">
          <td><?= $item->id ?></td>
          <td><?= $item->filename ?></td>
          <td><?= $item->record_lang ?></td>
          <td><?= Utils::formatBytes($item->filesize) ?></td>
          <td><?= $item->mime_type ?></td>
          <td>

The data directly rendering with short hand echo without any sanitation first, its recommend to use existing class of Strings::htmlentities on use phpMyFAQ\Strings;

<td><?= Strings::htmlentities($item->filename); ?></td>
<td><?= Strings::htmlentities($item->record_lang); ?></td>
<td><?= Utils::formatBytes($item->filesize) ?></td>
<td><?= Strings::htmlentities($item->mime_type); ?></td>

Propose fixing on that pull request https://github.com/thorsten/phpMyFAQ/pull/2827

PoC

An attacker with permission will upload the attachments image on http://{base_url}/admin/?action=editentry
On endpoint of ajax upload image POST /admin/index.php?action=ajax&ajax=att&ajaxaction=upload
Change the originally name file on parameters filename to a XSS payload
The XSS will trigger on attachment pages /admin/?action=attachments

Trigger XSS
Payload XSS <img width="1000" alt="image" src="https://user-images.githubusercontent.com/37658579/301022571-d6cdd166-b1f9-4062-87c5-c8bbb308cd5d.png">

Impact

This vulnerability will allow an attacker with a permissions of uploading an attachment to storing the payload of XSS on database specific table faqattachment columns filename.

The XSS payload could be rendering on page that listing the file on tables, and impact to others user that on the hierarchy.

The payload XSS have several attack scenario such like

Stealing the cookies (isn’t possible since HttpOnly)
Crashing the application with a looping javascript payload

Affected packages

Start with the recorded fix for your release branch. Check your installed version and test compatibility before upgrading. Fixing this advisory does not rule out other vulnerabilities in the release.

phpmyfaq/phpmyfaq Packagist

Ecosystem versions

Earlier releases before 3.2.5

Fixed in 3.2.5

121 explicitly affected versions

2.10.0-alpha, 2.8.0, 2.8.0-RC, 2.8.0-RC2, 2.8.0-RC3, 2.8.0-RC4, 2.8.0-alpha2, 2.8.0-alpha3, 2.8.0-beta, 2.8.0-beta2, 2.8.0-beta3, 2.8.1, 2.8.10, 2.8.11, 2.8.12, 2.8.13, 2.8.14, 2.8.15, 2.8.16, 2.8.17, 2.8.18, 2.8.19, 2.8.2, 2.8.20, 2.8.21, 2.8.22, 2.8.23, 2.8.24, 2.8.25, 2.8.26, 2.8.27, 2.8.28, 2.8.29, 2.8.3, 2.8.4, 2.8.5, 2.8.6, 2.8.7, 2.8.8, 2.8.9, 2.9.0, 2.9.0-alpha, 2.9.0-alpha2, 2.9.0-alpha3, 2.9.0-alpha4, 2.9.0-beta, 2.9.0-beta2, 2.9.0-rc, 2.9.0-rc2, 2.9.0-rc3, 2.9.0-rc4, 2.9.1, 2.9.10, 2.9.11, 2.9.12, 2.9.13, 2.9.2, 2.9.3, 2.9.4, 2.9.5, 2.9.6, 2.9.7, 2.9.8, 2.9.9, 3.0.0, 3.0.0-RC, 3.0.0-RC.2, 3.0.0-alpha, 3.0.0-alpha.2, 3.0.0-alpha.3, 3.0.0-alpha.4, 3.0.0-beta, 3.0.0-beta.2, 3.0.0-beta.3, 3.0.1, 3.0.10, 3.0.11, 3.0.12, 3.0.2, 3.0.3, 3.0.4, 3.0.5, 3.0.6, 3.0.7, 3.0.8, 3.0.9, 3.1.0, 3.1.0-RC, 3.1.0-alpha, 3.1.0-alpha.2, 3.1.0-alpha.3, 3.1.0-beta, 3.1.1, 3.1.10, 3.1.11, 3.1.12, 3.1.13, 3.1.14, 3.1.15, 3.1.16, 3.1.17, 3.1.18, 3.1.2, 3.1.3, 3.1.4, 3.1.5, 3.1.6, 3.1.7, 3.1.8, 3.1.9, 3.2.0, 3.2.0-RC, 3.2.0-RC.2, 3.2.0-RC.4, 3.2.0-alpha, 3.2.0-beta, 3.2.0-beta.2, 3.2.1, 3.2.2, 3.2.3, 3.2.4

View affected-version evidence

{
  "ranges": [
    {
      "events": [
        {
          "introduced": "0"
        },
        {
          "fixed": "3.2.5"
        }
      ],
      "type": "ECOSYSTEM"
    }
  ],
  "versions": [
    "2.10.0-alpha",
    "2.8.0",
    "2.8.0-RC",
    "2.8.0-RC2",
    "2.8.0-RC3",
    "2.8.0-RC4",
    "2.8.0-alpha2",
    "2.8.0-alpha3",
    "2.8.0-beta",
    "2.8.0-beta2",
    "2.8.0-beta3",
    "2.8.1",
    "2.8.10",
    "2.8.11",
    "2.8.12",
    "2.8.13",
    "2.8.14",
    "2.8.15",
    "2.8.16",
    "2.8.17",
    "2.8.18",
    "2.8.19",
    "2.8.2",
    "2.8.20",
    "2.8.21",
    "2.8.22",
    "2.8.23",
    "2.8.24",
    "2.8.25",
    "2.8.26",
    "2.8.27",
    "2.8.28",
    "2.8.29",
    "2.8.3",
    "2.8.4",
    "2.8.5",
    "2.8.6",
    "2.8.7",
    "2.8.8",
    "2.8.9",
    "2.9.0",
    "2.9.0-alpha",
    "2.9.0-alpha2",
    "2.9.0-alpha3",
    "2.9.0-alpha4",
    "2.9.0-beta",
    "2.9.0-beta2",
    "2.9.0-rc",
    "2.9.0-rc2",
    "2.9.0-rc3",
    "2.9.0-rc4",
    "2.9.1",
    "2.9.10",
    "2.9.11",
    "2.9.12",
    "2.9.13",
    "2.9.2",
    "2.9.3",
    "2.9.4",
    "2.9.5",
    "2.9.6",
    "2.9.7",
    "2.9.8",
    "2.9.9",
    "3.0.0",
    "3.0.0-RC",
    "3.0.0-RC.2",
    "3.0.0-alpha",
    "3.0.0-alpha.2",
    "3.0.0-alpha.3",
    "3.0.0-alpha.4",
    "3.0.0-beta",
    "3.0.0-beta.2",
    "3.0.0-beta.3",
    "3.0.1",
    "3.0.10",
    "3.0.11",
    "3.0.12",
    "3.0.2",
    "3.0.3",
    "3.0.4",
    "3.0.5",
    "3.0.6",
    "3.0.7",
    "3.0.8",
    "3.0.9",
    "3.1.0",
    "3.1.0-RC",
    "3.1.0-alpha",
    "3.1.0-alpha.2",
    "3.1.0-alpha.3",
    "3.1.0-beta",
    "3.1.1",
    "3.1.10",
    "3.1.11",
    "3.1.12",
    "3.1.13",
    "3.1.14",
    "3.1.15",
    "3.1.16",
    "3.1.17",
    "3.1.18",
    "3.1.2",
    "3.1.3",
    "3.1.4",
    "3.1.5",
    "3.1.6",
    "3.1.7",
    "3.1.8",
    "3.1.9",
    "3.2.0",
    "3.2.0-RC",
    "3.2.0-RC.2",
    "3.2.0-RC.4",
    "3.2.0-alpha",
    "3.2.0-beta",
    "3.2.0-beta.2",
    "3.2.1",
    "3.2.2",
    "3.2.3",
    "3.2.4"
  ]
}

Set up in your agent.

Investigate in your agent.