GHSA-7g7c-qhf3-x59p — propel/propel1 SQL injection possible with limit() on MySQL

The advisory, in context

The limit() query method is susceptible to catastrophic SQL injection with MySQL.

For example, given a model User for a table users:

UserQuery::create()->limit('1;DROP TABLE users')->find();

This will drop the users table!

The cause appears to be a lack of integer casting of the limit input in either Criteria::setLimit() or in DBMySQL::applyLimit(). The code comments there seem to imply that casting was avoided due to overflow issues with 32-bit integers.

This is surprising behavior since one of the primary purposes of an ORM is to prevent basic SQL injection.

This affects all versions of Propel: 1.x, 2.x, and 3.

Affected packages

Start with the recorded fix for your release branch. Check your installed version and test compatibility before upgrading. Fixing this advisory does not rule out other vulnerabilities in the release.

propel/propel1 Packagist

Ecosystem versions

From 1 before 1.7.2

Fixed in 1.7.2

10 explicitly affected versions

1.6.2, 1.6.3, 1.6.4, 1.6.5, 1.6.6, 1.6.7, 1.6.8, 1.6.9, 1.7.0, 1.7.1

View affected-version evidence

{
  "ranges": [
    {
      "events": [
        {
          "introduced": "1"
        },
        {
          "fixed": "1.7.2"
        }
      ],
      "type": "ECOSYSTEM"
    }
  ],
  "versions": [
    "1.6.2",
    "1.6.3",
    "1.6.4",
    "1.6.5",
    "1.6.6",
    "1.6.7",
    "1.6.8",
    "1.6.9",
    "1.7.0",
    "1.7.1"
  ]
}

Set up in your agent.

Investigate in your agent.

propel/propel1 SQL injection possible with limit() on MySQL

The advisory, in context

Affected packages

References